Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add returns to fetch-develop-deps #8233

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Add returns to fetch-develop-deps #8233

merged 1 commit into from
Jan 23, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 23, 2019

These look necessary for #8225
to work - the build is failing on jenkins

@dbkr
Add returns to fetch-develop-deps
a28691f 
These look necessary for #8225
to work - the build is failing on jenkins
@dbkr dbkr requested a review from a team January 23, 2019 11:43
jryans
jryans approved these changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, curious... Travis definitely proceeded to the second branch without this, so I wonder what's different about Jenkins... Seems worth a try anyway.

@dbkr dbkr merged commit 697c7f9 into experimental Jan 23, 2019
@t3chguy t3chguy deleted the dbkr/fetch_develop_deps_return branch May 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees

@dbkr dbkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @jryans